Adds test for GBPTree which auto-detects format changes #8585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinwelint
force-pushed
the
3.2-gbptree-format-version-test
branch
from
578e5fb
to
fe58e75
Compare
chrisvest
reviewed
Jan 9, 2017
| { | ||
| loadState( pagedFile ); | ||
| close(); | ||
| throw e; |
There was a problem hiding this comment.
If close() throws, for whatever reason, then that exception should be suppressed instead of shadowing the original exception.
tinwelint
force-pushed
the
3.2-gbptree-format-version-test
branch
from
ac1e105
to
fd16208
Compare
this test works by having a committed current-format.zip in src/test/resources and on failure reading and consistency checking that tree notifies developer that a FORMAT_VERSION needs to be incremented as well. When developer has incremented this version a new current-format.zip is generated and must be committed together with the other changes which changed the format.
tinwelint
force-pushed
the
3.2-gbptree-format-version-test
branch
from
fd16208
to
068a44d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this test works by having a committed current-format.zip in src/test/resources
and on failure reading and consistency checking that tree notifies developer that
a FORMAT_VERSION needs to be incremented as well. When developer has incremented
this version a new current-format.zip is generated and must be committed together
with the other changes which changed the format.