Preserve parameter type information in compiled runtime #8756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexaverbuch
force-pushed
the
3.2-birk-sort-param-type
branch
2 times, most recently
from
787ec20
to
98f53ea
Compare
systay
reviewed
Feb 7, 2017
|
|
||
| override def generateExpression[E](structure: MethodStructure[E])(implicit context: CodeGenContext): E = | ||
| structure.loadVariable(variableName) | ||
|
|
||
| override def nullable(implicit context: CodeGenContext) = true | ||
| override def nullable(implicit context: CodeGenContext) = cType.canBeNullable |
There was a problem hiding this comment.
Does this mean that params can now be non-nullable?
There was a problem hiding this comment.
AFAIK, yes, but only when assembling logical plans programmatically.
|
Looks good. Missing acceptance tests that make sure the parameter types are preserved |
alexaverbuch
force-pushed
the
3.2-birk-sort-param-type
branch
from
a04bb8b
to
fd6643e
Compare
- Fix ordering of nulls for nodes/relationships
- fix cases where orderability of Lists failed: Integer[], Long[], Float[], Double, float[], double[]
…ys to primitive streams
If a query variable already exists in the context we do not need to project it again.
To use primitive types internally we need to force unboxing in expectParameter
When node and relationship parameters are unboxed into primitives, we need to handle nulls properly (assign the dedicated null value of -1L).
…iables to context - removes unused CompiledConversionUtils.loadPrimitiveListParameter method
…tive longs to primitive longs
- it fails on compiled runtime, and making it green would unnecessarily delay the rest of the PR - this is not a regression, the test also fails against current 3.2 branch
- Reintroduce array parameter value test
alexaverbuch
force-pushed
the
3.2-birk-sort-param-type
branch
from
fd6643e
to
8e5b6b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for micro-benchmarking with lists of primitive types.
Also