Lowers batch size of input-reading stages in import #9341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because the batches would be quite big for data that has a large amount of property data and would risk out of memory. With this change the batch size is around a couple of thosands, down from a couple of tens of thousands (page size based)
| @@ -374,7 +374,7 @@ private void importRelationships( NodeRelationshipCache nodeRelationshipCache, | |||
|
|
|||
| private static Configuration configWithRecordsPerPageBasedBatchSize( Configuration source, RecordStore<?> store ) | |||
| { | |||
| return Configuration.withBatchSize( source, store.getRecordsPerPage() * 100 ); | |||
| return Configuration.withBatchSize( source, store.getRecordsPerPage() * 10 ); | |||
There was a problem hiding this comment.
Why not making it configurable?
There was a problem hiding this comment.
It's always painful introducing a config option for something that should just work. I don't think there's any benefit with the 100x multiplier... measuring as we speak
MishaDemianenko
approved these changes
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because the batches would be quite big for data that has a large
amount of property data and would risk out of memory. With this change
the batch size is around a couple of thosands, down from a couple of
tens of thousands (page size based)