-
Notifications
You must be signed in to change notification settings - Fork 136
Build and fixed compiled errors with respect to neo4j 1.6-SNAPSHOT version + Other Change #5
Conversation
Some minor refactor due to Neo4J 1.6-Snapshot
Nice to see a contribution in here :-) I see removal of jar files, but no addition of new ones? The diffs would be much better to read if you don't re-format existing code. You could use the Neo4j formatting template, found here: http://neo4j.github.com/ |
I have added only one new jar files in the 3rd commit as I felt other jar files are not necessary. When I removed the old jars I didn't find any problems when running the application. Please let me know if I should revert any of the commits. |
If you package it in this state, it won't work at all I think (running it from inside Eclipse IDE is a different story). However, for sure some features will be gone. The easiest route is to just keep the same set of jar files around but from the new version. Could you commit after using the formatter and add that commit to the pull request? The code has previously been formatted using the Eclipse formatter. |
Reverted all my previous changes and updated accordingly using the formatting template, Will appreciate your feedback. |
Fixed classpath in 'org.neo4j.neoclipse.doc' according to 1.6-Snapshot |
Guys, [12/17/11 5:06:00 PM] Peter Neubauer: !MESSAGE Missing required bundle org.eclipse.ui_[3.6.0,4.0.0). !ENTRY org.eclipse.osgi 4 0 2011-12-17 17:04:50.069 |
Are you trying after my commits? On Sun, Dec 18, 2011 at 2:24 PM, Peter Neubauer <
Thanks and Regards |
No, Cheers /peter Sent from a device with crappy keyboard and autocorrect
|
I also got that error before, but I did the following steps:
Under Main tab Under Plug-ins tab *And click run. Please try and let me know if you can able to run. It worked when I did this for the first time, but second time I got some Caused by: java.lang.ClassNotFoundException: On Sun, Dec 18, 2011 at 3:55 PM, Peter Neubauer <
Thanks and Regards |
Ha! Works. /peter On Sun, Dec 18, 2011 at 4:53 PM, Radhakrishna Kalyan
|
This looked nice, thanks a lot for the pull request! Do you have any other things you would like to see in Neoclipse? |
Hi, ya, i am working on that, as an issue raised by you. More over I have also plans to automate most of the code generations using Kalyan On Sun, Dec 18, 2011 at 5:10 PM, Peter Neubauer <
Thanks and Regards |
I wanted a connections view for ages now, would be great! |
Hi,
I am new to the world of plugin development. However I tried to add few functionalities.
Please review and give feedback.
I will be glad to here from you.
I have modified 2 features.
1> Added support for 1.6-Snapshot
2> Added icon to choose database location in the main screen beside preferences icon.
Kalyan