Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to support Neo4j 3+ #1

Merged
merged 13 commits into from
Dec 20, 2014
Merged

Conversation

dpisarewski
Copy link
Member

No description provided.

@subvertallchris
Copy link
Contributor

I'm guessing @reu won't be maintaining this anymore. Maybe he can transfer ownership of the repo and the gem on Rubygems to you?

@reu
Copy link
Member

reu commented Dec 17, 2014

True that, I was reviewing the code, and realised that all the APIs changed and I didn't even notice. Would you like to maintain it @dpisarewski?

@subvertallchris
Copy link
Contributor

We could also take control of it at https://github.com/neo4jrb. I'm happy to make a team and give you guys access to it. We're trying to use that as a hub for stuff as much as possible.

@reu
Copy link
Member

reu commented Dec 17, 2014

Great @subvertallchris, that's seen the ideal solution!

@subvertallchris
Copy link
Contributor

Awesome! Just transfer ownership to neo4jrb, if you don't mind. I'll create a team and invite you guys to it. My Rubygems account is registered to chris@subvertallmedia.com, if you can give me access to that, too. @dpisarewski, are you on Rubygems?

@reu
Copy link
Member

reu commented Dec 17, 2014

I tried, but it seen I need admin rights on the neo4j organisation to do it. The error message Github is returning is: "You don't have admin rights to neo4jrb"

@subvertallchris
Copy link
Contributor

Ah, my bad, I guess it works differently with orgs. Can you add me as an owner of this gem and I'll move it?

@reu
Copy link
Member

reu commented Dec 17, 2014

Okay

@subvertallchris
Copy link
Contributor

Done! Awesome, great work on this and thanks for bringing it over. Having things connected to the Neo4jrb project helps everyone. I sent you guys both invites to the team so you can have full control over this repo.

@subvertallchris
Copy link
Contributor

@reu Would you mind adding me to the gem on Rubygems? gem owner carrierwave-neo4j -a chris@subvertallmedia.com

@reu
Copy link
Member

reu commented Dec 19, 2014

Done =]

@reu reu closed this Dec 19, 2014
subvertallchris added a commit that referenced this pull request Dec 20, 2014
Updated to support Neo4j 3+
@subvertallchris subvertallchris merged commit 7f5e35b into neo4jrb:master Dec 20, 2014
@subvertallchris
Copy link
Contributor

Was gonna leave it for @dpisarewski to merge but got antsy so I did it myself. ;-)

amitsuryavanshi pushed a commit that referenced this pull request Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants