New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix specs #297

Merged

cheerfulstoic merged 8 commits into neo4jrb:master from klobuczek:fix_specs

Jul 13, 2017

Member

klobuczek commented Jun 29, 2017 •

edited

Loading

Made travis configuration changes to make build pass.

Fixes #

This pull introduces/changes:

Memory configuration changes
Used extremely long sleep after neo4j:start as in some cases the startup process took over 1 minute, this has to be fixed with a better ready detection strategy in rake neo4j:start (another day in another PR)
Refreshed the tested ruby and neo4j versions
Removed identical spec block
exluded spec directory from coveralls, we should measure the code percentage the specs cover while the specs code itself should not be measured as in my case above removing an identical block of specs which were actually hit reduced the percentage of hit lines. Now the coverage is reported much lower but that is the correct number. Once this PR is accepted the future deltas will be adequate.

Pings:
@cheerfulstoic
@subvertallchris


          attempting to fix specs, removed duplicated block in specs, updates .…

025b171

…travis.yml

coveralls commented Jun 29, 2017 •

edited

Loading

Coverage decreased (-0.02%) to 83.747% when pulling 025b171 on klobuczek:fix_specs into 255a773 on neo4jrb:master.

2 similar comments

coveralls commented Jun 29, 2017

Coverage decreased (-0.02%) to 83.747% when pulling 025b171 on klobuczek:fix_specs into 255a773 on neo4jrb:master.

coveralls commented Jun 29, 2017

Coverage decreased (-0.02%) to 83.747% when pulling 025b171 on klobuczek:fix_specs into 255a773 on neo4jrb:master.

klobuczek added 2 commits

June 29, 2017 21:41


          debugging travis

410fdf4


          removing travis_debug

d5fe65f

coveralls commented Jun 29, 2017

Coverage increased (+8.8%) to 92.608% when pulling d5fe65f on klobuczek:fix_specs into 255a773 on neo4jrb:master.

klobuczek added 2 commits

June 29, 2017 21:53


          finished debugging

65db050


          replicating memory config from neo4j/neo4j

0072b43

coveralls commented Jun 29, 2017 •

edited

Loading

Coverage decreased (-0.02%) to 83.747% when pulling 65db050 on klobuczek:fix_specs into 255a773 on neo4jrb:master.


          exposing neo4j logs and config

ece6613

coveralls commented Jun 29, 2017 •

edited

Loading

Coverage decreased (-0.02%) to 83.747% when pulling 0072b43 on klobuczek:fix_specs into 255a773 on neo4jrb:master.

coveralls commented Jun 29, 2017 •

edited

Loading

Coverage decreased (-0.02%) to 83.747% when pulling ece6613 on klobuczek:fix_specs into 255a773 on neo4jrb:master.


          excluding spec from coverage

788454b

coveralls commented Jun 29, 2017 •

edited

Loading

Coverage decreased (-10.1%) to 73.664% when pulling 788454b on klobuczek:fix_specs into 255a773 on neo4jrb:master.

5 similar comments

coveralls commented Jun 29, 2017

Coverage decreased (-10.1%) to 73.664% when pulling 788454b on klobuczek:fix_specs into 255a773 on neo4jrb:master.

coveralls commented Jun 29, 2017

Coverage decreased (-10.1%) to 73.664% when pulling 788454b on klobuczek:fix_specs into 255a773 on neo4jrb:master.

coveralls commented Jun 29, 2017

Coverage decreased (-10.1%) to 73.664% when pulling 788454b on klobuczek:fix_specs into 255a773 on neo4jrb:master.

coveralls commented Jun 29, 2017

Coverage decreased (-10.1%) to 73.664% when pulling 788454b on klobuczek:fix_specs into 255a773 on neo4jrb:master.

coveralls commented Jun 29, 2017

Coverage decreased (-10.1%) to 73.664% when pulling 788454b on klobuczek:fix_specs into 255a773 on neo4jrb:master.


          massively increasing sleep after neo4j start

63b8b5d

coveralls commented Jun 29, 2017 •

edited

Loading

Coverage decreased (-10.1%) to 73.664% when pulling 63b8b5d on klobuczek:fix_specs into 255a773 on neo4jrb:master.

2 similar comments

coveralls commented Jun 29, 2017

Coverage decreased (-10.1%) to 73.664% when pulling 63b8b5d on klobuczek:fix_specs into 255a773 on neo4jrb:master.

coveralls commented Jun 29, 2017

Coverage decreased (-10.1%) to 73.664% when pulling 63b8b5d on klobuczek:fix_specs into 255a773 on neo4jrb:master.

klobuczek mentioned this pull request

Added aliases to Relationship #298

Merged

Contributor

cheerfulstoic commented Jul 13, 2017

Awesome, thanks!

cheerfulstoic merged commit 5cf497a into neo4jrb:master

cheerfulstoic pushed a commit that referenced this pull request


          Fix specs (#297)

34739ac

* attempting to fix specs, removed duplicated block in specs, updates .travis.yml

* debugging travis

* removing travis_debug

* finished debugging

* replicating memory config from neo4j/neo4j

* exposing neo4j logs and config

* excluding spec from coverage

* massively increasing sleep after neo4j start

(cherry picked from commit 5cf497a)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet