-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use stylelint-vscode from vscode-stylelint #10
Use stylelint-vscode from vscode-stylelint #10
Conversation
Apparently I have still something to do as diagnostics don't show up in nvim. I've try to log things from here with something like const d = await stylelintVSCode(document, options);
connection.window.showErrorMessage(`stylelint: ${JSON.stringify(d)}`) ;
connection.sendDiagnostics({
uri: document.uri,
diagnostics: await stylelintVSCode(document, options)
}) I do see the diagnostics in the error message. I don't understand what is going on and as I'm not familiar with coc and vscode extensions I don't know where to look for errors. Any hint @chemzqm ? |
|
40861f3
to
dfd8f95
Compare
Ok, I've updated the field to Here is my
|
dfd8f95
to
5699923
Compare
Ok, it's ready @chemzqm. My problem was that |
We should not use source code from github directly, since it can be easily broken, we could rework it like https://github.com/stylelint/vscode-stylelint |
Ok I understand. The stylelint/vscode-stylelint team has an issue to publish stylelint-vscode back to npm (stylelint/vscode-stylelint#65). I will watch their progress and push another PR once the npm package is published again, if that sounds ok for you |
Fixes #9
This PR to use the latest
stylelint-vscode
lib (now invscode-stylelint
) in order to take advantage of stylelint/vscode-stylelint#26