Changed to load stylelint from local node modules #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we also remove stylelint from dependencies? And make clear in readme that locally installed version will be used? |
I think we leave it as is now, as users can continue to use the bundled styleint: We can discuss and remove the stylelint dependency in a v1.0.0 release |
I have added to the README. |
…al_module # Conflicts: # lib/stylelint-vscode/index.js
ntwb
approved these changes
Jan 5, 2020
This was referenced Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4
Closes #20
This PR makes changed to load stylelint from local node modules.
With this change, users can use their installed stylelint.
Resolve stylelint module in the following priority order: