Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vscode pyright extention #1146

Closed
fonghou opened this issue Sep 5, 2019 · 3 comments
Closed

Support vscode pyright extention #1146

fonghou opened this issue Sep 5, 2019 · 3 comments

Comments

@fonghou
Copy link
Contributor

fonghou commented Sep 5, 2019

Is your feature request related to a problem? Please describe.
Microsoft put out a type check pyright. It'll be a great addition to coc.nvim.

Describe the solution you'd like
pyright is implemented in pure typescript (5x faster than mypy), with tight integration in vscode. It seems fit coc.nvim's design very well.

Describe alternatives you've considered
pyright doesn't provide a standalone lsp server. microsoft/pyright#99 has some details.

Additional context
https://marketplace.visualstudio.com/items?itemName=ms-pyright.pyright

@fannheyward
Copy link
Member

@fonghou
Copy link
Contributor Author

fonghou commented Sep 6, 2019

@fannheyward, thanks for working it so quickly!

I just test it briefly. It works great, however, it seems not picking up pyrightconfig.json.

@chemzqm chemzqm closed this as completed Sep 9, 2019
@chemzqm
Copy link
Member

chemzqm commented Sep 9, 2019

You can create issue at https://github.com/fannheyward/coc-pyright/issues

@chemzqm chemzqm reopened this Sep 9, 2019
@chemzqm chemzqm closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants