added mdx filetype identifier #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fannheyward
approved these changes
Mar 23, 2020
|
Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As I tried to transplant a vscode plugin, activationEvents does not trigger on opening mdx files.
Cause
mdx is not a built-in filetype of vscode language server at the moment.
The contributes.languages feature of allows vscode extensions to define their own filetype, i.e. extensions mapped to language identifier. Therefore vscode-mdx works fine without the official support of mdx filetype from vscode.
However coc.nvim is lack of this feature at the moment.
Fix
I will eventually try to implement this feature. But I wish to focus on the original problem, which is to transplant vscode-mdx to coc. So a dirty and temporary workaround is made.
The change has been kept minimal. Please check if anything will be broken by this PR.