Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined variable: size error of coc#pum#scroll() & coc#pum#info() support reversed #4131

Merged
merged 1 commit into from Sep 1, 2022
Merged

Conversation

qiqiboy
Copy link
Contributor

@qiqiboy qiqiboy commented Sep 1, 2022

No description provided.

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #4131 (50a3a96) into master (d386165) will increase coverage by 0.05%.
The diff coverage is 89.23%.

@@            Coverage Diff             @@
##           master    #4131      +/-   ##
==========================================
+ Coverage   86.66%   86.72%   +0.05%     
==========================================
  Files         249      248       -1     
  Lines       23628    23634       +6     
  Branches     5346     5352       +6     
==========================================
+ Hits        20478    20497      +19     
+ Misses       1506     1505       -1     
+ Partials     1644     1632      -12     
Impacted Files Coverage Δ
src/handler/index.ts 95.04% <ø> (-0.05%) ⬇️
src/types.ts 100.00% <ø> (ø)
src/provider/manager.ts 91.11% <60.00%> (-8.89%) ⬇️
src/handler/locations.ts 97.27% <92.85%> (+3.52%) ⬆️
src/core/documents.ts 91.20% <94.44%> (+2.73%) ⬆️
src/languages.ts 96.68% <100.00%> (ø)
src/provider/declarationManager.ts 100.00% <100.00%> (ø)
src/provider/definitionManager.ts 100.00% <100.00%> (ø)
src/provider/implementationManager.ts 100.00% <100.00%> (ø)
src/provider/referenceManager.ts 100.00% <100.00%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chemzqm chemzqm merged commit c088404 into neoclide:master Sep 1, 2022
chemzqm added a commit that referenced this pull request Sep 1, 2022
a5276d6 feat(locations): highlight targetRange on preview when possible
c543d8a fix(list): allow --reverse in scheme
c088404 Fix `undefined variable: size` error of coc#pum#scroll() & coc#pum#info() support `reversed` (#4131)
5ba1b96 refactor(tests): configuretion > configuration (#4130)
8a6a8e1 refactor(locations): use LocationWithTarget
d386165 feat(document): support b:coc_force_attach
a09d279 feat(completion): support suggest.asciiMatch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants