Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add coc.preferences.tagDefinitionTimeout #4601

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

gou4shi1
Copy link
Contributor

@gou4shi1 gou4shi1 commented Apr 10, 2023

I'm using set tagfunc=CocTagFunc
To avoid <C-] stuck for a very long time.

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.01 ⚠️

Comparison is base (628f08a) 98.76% compared to head (f2e7960) 98.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4601      +/-   ##
==========================================
- Coverage   98.76%   98.75%   -0.01%     
==========================================
  Files         273      273              
  Lines       25913    25920       +7     
  Branches     5375     5376       +1     
==========================================
+ Hits        25592    25597       +5     
- Misses        186      188       +2     
  Partials      135      135              
Impacted Files Coverage Δ
src/handler/locations.ts 96.61% <50.00%> (-3.39%) ⬇️

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fannheyward
Copy link
Member

Thank you for your PR, this works!

I'd prefer to add the timeout configuration like coc.preferences.tagDefinitionTimeout, most coc.nvim configurations prefer to schema.json, especially used in TypeScript codes.

@gou4shi1 gou4shi1 changed the title feat: add coc_get_tag_timeout feat: add coc.preferences.tagDefinitionTimeout Apr 10, 2023
@gou4shi1
Copy link
Contributor Author

@fannheyward Thanks for your review, any other comment?

@fannheyward fannheyward merged commit 3014125 into neoclide:master Apr 11, 2023
chemzqm added a commit that referenced this pull request Jul 26, 2023
3dc6153 Correct spelling `resutl` to `result` (#4711)
3d14e72 chore(deps): bump word-wrap from 1.2.3 to 1.2.4 (#4706)
2280f9a chore(deps): bump semver from 7.5.0 to 7.5.2 (#4685)
1df60fc docs: fix wrong prefix of CocList command options, ref commit 1d3b424 (#4631)
537f12b fix(rpc): fix unknown function error (#4675)
2a0e554 feat(ci): test with nvim nightly (#4661)
edcc376 chore(README): improve mappings (#4510)
0df7380 fix(notify): use nvim_buf_set_lines for nvim (#4542)
5704b37 chore(exception): typo workspaceContains (#4545)
19c782e chore(yarn): upgrade dev-dependencies (#4627)
e51a7cd fix(list): fix opening an empty buffer in the help action of the extensions (#4652)
3014125 feat: add coc.preferences.tagDefinitionTimeout (#4601)
43f4daa fix(util): properly escape breakat (#4597)
628f08a fix: hide list correctly on vim (#4584)
94dc105 fix(api): Fix Buffer.getVar() for non-current buffer (#4569)
b28b8dc fix(util): patchLine, byte aligned (#4526)
79e9e04 Fix typos and grammatical errors (#4521)
59a942d docs: fix typo termainal -> terminal (#4514)
8c0d3ef fix(semanticTokens): make indexing of highlight groups more consistent (#4500)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants