feat(inlayHint): add document enable/disable inlayHint commands. #5025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
{enable,disable}InlayHintcommands. The base istoggleInlayHint, but this allows more control.I wanted to disable inlay hints in
insertmode, but without knowing the state of the inlayHints, calling toggle was not option. Additionally, just disabling (regardless of whether it's on) or enabling may be useful for other autocommands.Unfortunately, I could not find a way to get configuration or state of the display hints, which is also critical to more advanced autocommands.
This PR is based on
toggleInlayHint, but I could not find examples of how either configuration can be exposed to Lua/Autocommands nor current state whether it's displayed or not. This is the reason this is a draft, I would love to hear feedback about getting the configuration and current state from the Lua and how to make it happen.