Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump puppeteer to v0.13.0 #26

Closed
neocotic opened this issue Nov 21, 2017 · 1 comment
Closed

Bump puppeteer to v0.13.0 #26

neocotic opened this issue Nov 21, 2017 · 1 comment
Assignees
@neocotic
Labels
enhancement
Milestone
0.3.2

Comments

@neocotic
Copy link
Owner

puppeteer v0.13.0 has been released so I would like to update our version on convert-svg-core to match. Nothing major, but I did see some enhancements/fixes relating to screenshot capturing that could possibly benefit us. Worth keeping up-to-date regardless.
@neocotic neocotic added this to the 0.3.2 milestone Nov 21, 2017
@neocotic neocotic self-assigned this Nov 21, 2017
neocotic added a commit that referenced this issue Nov 21, 2017
@neocotic
chore(convert-svg-core): Bumped puppeteer to v0.13.0 #26
d9fdd72
@neocotic
Copy link
Owner Author

This has been implemented in d9fdd72 and will be included in the 0.3.2 release.

I had to update the expected output for some unit tests. I'm not sure why but it's most likely a result of puppeteer/puppeteer#1315. It doesn't appear to make a difference to the visual output though, as far as I can tell. Considering it was a bug fix, I can only hope that it's fixed something about the output.

@neocotic neocotic mentioned this issue Nov 21, 2017
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neocotic neocotic

Labels
enhancement
Projects
None yet
Milestone
0.3.2
Development

No branches or pull requests
1 participant
@neocotic