Add process.browser check for inNode #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've not forgotten about this... Honest. I'm just trying to find time to get some familiarity with browserify so that I can judge the change. I do want to do this though as it's becoming a common request across my projects. |
|
LGTM 👍 |
|
This library has been seriously restructured in an attempt to provide better support for various packaging tools. V2 (aka QRious #48) should now provide fully support for browserify. Sorry for taking so long to reply to this and thanks for using this library. I hope you find the the newer version easier to use and better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check allows people to use the module with Browserify. Otherwise it will attempt to load the node modules.