Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QRious #48

Merged
merged 43 commits into from Jun 26, 2016
Merged

QRious #48

merged 43 commits into from Jun 26, 2016

Conversation

neocotic
Copy link
Owner

@neocotic neocotic commented Jun 26, 2016

  • Rename library to QRious and move package from qr-js to qrious
  • Completely redesign API to follow OOP pattern for simplicity
  • Remove save and saveSync method
  • Remove noConflict method
  • Remove documentation generated by docco
  • Restructure code base to make it more maintainable and use Rollup to build it
  • Provide better built-in support for Browserify and Webpack etc
  • Switch from JSHint to ESLint
  • Add demo.html to allow contributors to experiment and test with changes due to lack of unit tests
  • Remove INSTALL.md and consolidate contents into README.md and CONTRIBUTING.md
  • Add support for Travis CI

neocotic added 30 commits May 3, 2016 18:15
…sed when the QR size isn't big enough for the contents is handled more gracefully
@neocotic neocotic self-assigned this Jun 26, 2016
@neocotic neocotic added this to the 2.0.0 milestone Jun 26, 2016
@neocotic
Copy link
Owner Author

This has involved a lot of work and I'm sorry it took so long and that the migration won't be seamless. You will, unfortunately, have to rewrite your code to fit with the new QRious library.

I plan on documenting the migration within the next 24 hours that will hopefully cover how to migrate as easily as possible below:

https://github.com/neocotic/qr.js/wiki/Migrating-from-v1

This is only the first step. I plan on restructuring the project even further in a v3 which will split it up into 3 modules: qrious-core, qrious-browser, qrious-node. This should make it much easier to install in the future as I feel it can still be a bit confusing due to the node-canvas dependency.

@neocotic
Copy link
Owner Author

#28 will hopefully be fixed as a result of these changes.

#31 will become invalid since the save and saveSync methods have been dropped.

@neocotic
Copy link
Owner Author

Finally got travis building node-canvas correctly on all Node.js versions. Ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant