Rewrite code in ES5 #81
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,2 @@ | ||
| dist/ | ||
| Gruntfile.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,37 +20,10 @@ | |
| 'use strict'; | ||
|
|
||
| module.exports = function(grunt) { | ||
| var commonjs = require('rollup-plugin-commonjs'); | ||
| var nodeResolve = require('rollup-plugin-node-resolve'); | ||
| var uglify = require('rollup-plugin-uglify'); | ||
|
|
||
| grunt.initConfig({ | ||
| pkg: grunt.file.readJSON('package.json'), | ||
|
|
||
|
|
@@ -63,55 +36,42 @@ module.exports = function(grunt) { | |
| }, | ||
|
|
||
| rollup: { | ||
| umdDevelopment: { | ||
| options: { | ||
| format: 'umd', | ||
| moduleId: 'qrious', | ||
| moduleName: 'QRious', | ||
| sourceMap: true, | ||
| sourceMapRelativePaths: true, | ||
| banner: [ | ||
| '/*', | ||
| ' * QRious v<%= pkg.version %>', | ||
| ' * Copyright (C) <%= grunt.template.today("yyyy") %> <%= pkg.author.name %>', | ||
| ' * Copyright (C) 2010 Tom Zerucha', | ||
| ' *', | ||
| ' * This program is free software: you can redistribute it and/or modify', | ||
| ' * it under the terms of the GNU General Public License as published by', | ||
| ' * the Free Software Foundation, either version 3 of the License, or', | ||
| ' * (at your option) any later version.', | ||
| ' *', | ||
| ' * This program is distributed in the hope that it will be useful,', | ||
| ' * but WITHOUT ANY WARRANTY; without even the implied warranty of', | ||
| ' * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the', | ||
| ' * GNU General Public License for more details.', | ||
| ' *', | ||
| ' * You should have received a copy of the GNU General Public License', | ||
| ' * along with this program. If not, see <http://www.gnu.org/licenses/>.', | ||
| ' */' | ||
| ].join('\n'), | ||
| plugins: function() { | ||
| return [ | ||
| nodeResolve({ main: true }), | ||
| commonjs() | ||
| ]; | ||
| } | ||
| }, | ||
| files: { | ||
| 'dist/qrious.js': 'src/runtime/browser.js' | ||
| } | ||
| }, | ||
| umdProduction: { | ||
|
|
@@ -121,18 +81,15 @@ module.exports = function(grunt) { | |
| moduleName: 'QRious', | ||
| sourceMap: true, | ||
| sourceMapRelativePaths: true, | ||
| banner: [ | ||
| '/*! QRious v<%= pkg.version %> | (C) <%= grunt.template.today("yyyy") %> <%= pkg.author.name %> | GPL v3 License', | ||
| 'Based on jsqrencode | (C) 2010 tz@execpc.com | GPL v3 License', | ||
| '*/' | ||
| ].join('\n'), | ||
| plugins: function() { | ||
| return [ | ||
| nodeResolve({ main: true }), | ||
| commonjs(), | ||
| uglify({ | ||
| output: { | ||
| comments: function(node, comment) { | ||
|
|
@@ -144,7 +101,7 @@ module.exports = function(grunt) { | |
| } | ||
| }, | ||
| files: { | ||
| 'dist/qrious.min.js': 'src/runtime/browser.js' | ||
|
There was a problem hiding this comment. Since UMD is now the only distribution format that's generated by the build, I've moved its files to the This will be a breaking changed for those using the CDN download links referenced in the README, but I fear that it's best. If I get enough kickback, I might add symbolic links, otherwise, I will recommend that they simply change their URLs as follows for the 2.3.0:
The download links in the README have been updated as part as this PR. |
||
| } | ||
| } | ||
| }, | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to highlight that the CommonJS distribution file has been removed and is no longer generated by the build since Node.js modules will now import the
src/runtime/node.jsmodule directly as it is the new "main" entry inpackage.json.