-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework server resources #111
Draft
IchHabeHunger54
wants to merge
28
commits into
neoforged:main
Choose a base branch
from
IchHabeHunger54:rework/server-resources
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Rework server resources #111
IchHabeHunger54
wants to merge
28
commits into
neoforged:main
from
IchHabeHunger54:rework/server-resources
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Deploying with Cloudflare Pages
|
…() calls (1.21 change)
…n.create() calls (1.21 change)" This reverts commit 1457e3f.
…mespaceAndPath() calls (1.21 change)
83 tasks
ChampionAsh5357
requested changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, done taking a quick look. This will need another pass from the author since it doesn't seem to have been updated past 1.20.4.
…/server-resources # Conflicts: # docs/datagen/loottables.md # docs/datagen/tags.md # docs/datamaps/index.md # docs/resources/server/advancements.md # docs/resources/server/conditional.md # docs/resources/server/glm.md # docs/resources/server/loottables.md # docs/resources/server/recipes/custom.md # docs/resources/server/recipes/incode.md # docs/resources/server/tags.md
dhyces
reviewed
Jun 23, 2024
# Conflicts: # docs/datamaps/index.md # docs/resources/server/advancements.md
# Conflicts: # docs/datamaps/index.md # docs/resources/server/advancements.md # docs/resources/server/loottables.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #62. This PR:
This PR explicitly does not do anything worldgen-related, that deserves its separate PR(s).
Once done: closes #83, closes #84, closes #94.
Opening as draft so people can already give feedback before the final version. Will undraft after recipe docs are reworked.
Preview URL: https://pr-111.neoforged-docs-previews.pages.dev