Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework server resources #111

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

IchHabeHunger54
Copy link
Member

@IchHabeHunger54 IchHabeHunger54 commented Jun 12, 2024

Follow-up to #62. This PR:

  • Reworks and expands the server data section. This includes:
    • The advancements article.
    • The conditons article.
    • The GLM article.
    • The loot tables article.
    • The recipe and ingredient articles. (TODO)
    • The tags article.
  • Adds a new damage types/damage sources article.
  • Merges the datagen articles into the "parent" articles. (Advancements datagen -> advancements article, tags datagen -> tags article, etc.)
    • Also expands on the datagen articles, and adds some missing parts.
  • Does some minor restructuring.
    • Moves data maps into the server section. Also merges data map datagen into the main data map article.
    • Makes loot a subsection of the server section, with loot tables as the main article, and GLMs and loot table datagen as sub-articles.
  • Adjusts references as necessary.

This PR explicitly does not do anything worldgen-related, that deserves its separate PR(s).

Once done: closes #83, closes #84, closes #94.

Opening as draft so people can already give feedback before the final version. Will undraft after recipe docs are reworked.


Preview URL: https://pr-111.neoforged-docs-previews.pages.dev

@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) June 12, 2024 14:52 Active
@neoforged-pages-deployments
Copy link

neoforged-pages-deployments bot commented Jun 12, 2024

Deploying with Cloudflare Pages

Name Result
Last commit: dc1898dfd5abf38d4daa9f6e0e73b59076187f32
Status: ✅ Deploy successful!
Preview URL: https://66a3805f.neoforged-docs-previews.pages.dev
PR Preview URL: https://pr-111.neoforged-docs-previews.pages.dev

@IchHabeHunger54 IchHabeHunger54 added addition Adding or rewriting information. large Major additions or changes. labels Jun 12, 2024
@IchHabeHunger54 IchHabeHunger54 requested a review from a team June 12, 2024 16:41
Copy link
Contributor

@ChampionAsh5357 ChampionAsh5357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done taking a quick look. This will need another pass from the author since it doesn't seem to have been updated past 1.20.4.

docs/items/index.md Outdated Show resolved Hide resolved
docs/items/index.md Outdated Show resolved Hide resolved
docs/items/index.md Outdated Show resolved Hide resolved
docs/items/index.md Outdated Show resolved Hide resolved
docs/items/index.md Outdated Show resolved Hide resolved
docs/resources/server/damagetypes.md Outdated Show resolved Hide resolved
docs/resources/server/damagetypes.md Outdated Show resolved Hide resolved
docs/resources/server/damagetypes.md Outdated Show resolved Hide resolved
docs/resources/server/damagetypes.md Outdated Show resolved Hide resolved
docs/resources/server/damagetypes.md Outdated Show resolved Hide resolved
…/server-resources

# Conflicts:
#	docs/datagen/loottables.md
#	docs/datagen/tags.md
#	docs/datamaps/index.md
#	docs/resources/server/advancements.md
#	docs/resources/server/conditional.md
#	docs/resources/server/glm.md
#	docs/resources/server/loottables.md
#	docs/resources/server/recipes/custom.md
#	docs/resources/server/recipes/incode.md
#	docs/resources/server/tags.md
# Conflicts:
#	docs/datamaps/index.md
#	docs/resources/server/advancements.md
# Conflicts:
#	docs/datamaps/index.md
#	docs/resources/server/advancements.md
#	docs/resources/server/loottables.md
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) June 28, 2024 20:52 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) June 28, 2024 21:17 Active
@neoforged-pages-deployments neoforged-pages-deployments bot deployed to neoforged-docs-previews (Preview) June 30, 2024 02:44 Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition Adding or rewriting information. large Major additions or changes.
Projects
None yet
3 participants