-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the Client Resources chapter #62
Conversation
Co-authored-by: Dennis C <xfacthd@gmx.de>
Co-authored-by: Dennis C <xfacthd@gmx.de>
Co-authored-by: ChampionAsh5357 <championash5357@gmail.com>
…nd language articles
…, add new texture article
Deploying with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, here are my overall comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thought and the remaining unresolved comments. Otherwise, looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only looked at the baked model stuff I am familiar with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
Probably the biggest rework yet: the Resources chapter. I originally wanted to redo the entire Resources chapter at once, but given the sheer scope of that, I decided to split it into two: client and server. So client resources rework first it is.
This PR:
json5
for JSON blocks instead ofjs
(to allow comments), as discussed on Discord. This guideline change is not applied to existing articles, only to new ones.I made a few general design decisions in this PR that I'd like to outline here:
Preview URL: https://pr-62.neoforged-docs-previews.pages.dev