Fixing and cleaning up configs #40
Conversation
Who edits the config via a file when minecraft is already running?
Since `ConfigFileTypeHandler` is extensible and `ModConfig` already has everything ready for it
Some mods add screens to edit configs and they should fire an event via this method
Resolves todo
| @@ -23,10 +23,12 @@ | |||
| public class FMLConfig | |||
| { | |||
| public enum ConfigValue { | |||
| DISABLE_CONFIG_WATCHER("disableConfigWatcher", Boolean.FALSE, "Disables File Watcher. Used to automatically update config if its file has been modified."), | |||
There was a problem hiding this comment.
What is the point of disabling the config watcher? If it is to fix a bug, it might already be fixed in upstream NightConfig. Or at least it was reported to TheElectronWill some time ago and he said a fix was in the pipeline?
There was a problem hiding this comment.
Basically, there's no point as such, but I'd like to be able to do so
There was a problem hiding this comment.
FWIW, I'm in favor of this change - there are outstanding issues with the watcher on our end that are not addressed, such as the Loading & Reloading events being able to fire simultaneously, and the whole concept being quite broken with editors that don't save atomically. So I think giving users the option to disable the watcher is a good stopgap until someone has time to properly rewrite that logic.
There was a problem hiding this comment.
Should we maybe disable it by default then for now? (at least in production)
There was a problem hiding this comment.
How about a complete remove?
There was a problem hiding this comment.
No - it would be nice to fix it eventually so please leave it in.
There was a problem hiding this comment.
Ok, what else do I need to do to get this pr merged? (I can't continue working on one mod without these changes)
core/src/main/java/net/neoforged/fml/config/ConfigFileTypeHandler.java
Outdated
Show resolved
Hide resolved
|
The changes look fine to me but I'd like someone else to take a look. |
|
I'll do some testing later. |
|
Hello |
The things that keep me from sleeping well. Commits are documented (if possible),
Perhaps after merge this pr I will make an additional one for neoforge, however right now it is not required and does not make any breaking changes (Probably)