Optimize the file watcher

[TheElectronWill]

• Use only one WatchService per filesystem
• Add a configurable throttling delay to avoid reloading configuration too often (todo: make it a debounce instead)
• Use WatchService#poll(timeout, unit) instead of poll() to wait for events instead of busy looping
• and more improvements :)

[comp500]

Changes look good to me, thanks for looking into this!

[solonovamax]

Is there any way this can get merged? It seems that night-config is hammering my filesystem which is, uh, Not Nice™

and if for whatever reason this can't be merged quickly, could a quick-and-dirty change at least be introduced that at adds Thread.sleep(1000L) in between checking if the config has updated?

[TheElectronWill]

Yes! I'd like to add a bit more tests and then I'll merge it. Not so fan of a quick-and-dirty fix, the real one will be much better :p

[solonovamax]

Not so fan of a quick-and-dirty fix, the real one will be much better :p

I do agree with this, but it's really hammering my disk causing significant issues with other programs (where programs like IntelliJ take several times longer to load files than it should) unless I close minecraft. (I'm not entirely sure that this is the cause, but I believe that it is)
So, honestly, I'd love just to have a temporary solution in the meantime. (Though, I might just clone the branch and build it myself lol. but afaik a few of the mods I have shade it directly into the jar lol)

[TheElectronWill]

I do agree with this, but it's really hammering my disk causing significant issues with other programs (where programs like IntelliJ take several times longer to load files than it should) unless I close minecraft. (I'm not entirely sure that this is the cause, but I believe that it is)

How many configs do you have? Do you modify them while playing? The FileWatcher is watching for changes through the OS, it doesn't do much when there's no change 🤔

Inspecting the Minecraft process with a tool like VisualVM would provide some insights.

[solonovamax]

How many configs do you have? Do you modify them while playing? The FileWatcher is watching for changes through the OS, it doesn't do much when there's no change 🤔

It might not be the filewatcher causing this, could be smth else, but I just took an educated guess based on absolutely nothing, that this was the cause of this lol