Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds winDir scatter plot as per issue #57 #61

Closed
wants to merge 10 commits into from
Closed

Adds winDir scatter plot as per issue #57 #61

wants to merge 10 commits into from

Conversation

W0CHP
Copy link

@W0CHP W0CHP commented Oct 21, 2022

Per issue #57 , this PR adds windDir scatter plots to templates.

@seehase
Copy link

seehase commented Nov 6, 2022

Hi @W0CHP
There is a small bug in the templates for yesterday, week, month and year templates when using windDir
The graph-type is "line" but the config is not defined

You need to add

  var graph_line_config = {
    #include "graph_line_config.inc"
  }

to the template, as it is already in the "year-%Y-$m.html.tmpl" for example
see here
https://github.com/seehase/neowx-material/blob/9ef0d2725e8eeb9043fef5efbcb0844879a49794/src/year.html.tmpl#L319

@W0CHP
Copy link
Author

W0CHP commented Nov 6, 2022

@seehase thanks! I've fixed the issue :)

@seehase
Copy link

seehase commented Nov 6, 2022

I can see " All-Time Records" in your stat... I like to add this too... How did you do this?
alos like the icons in your headlines.
can you send me the code ... or create a PR for my fork ;-)

@W0CHP
Copy link
Author

W0CHP commented Nov 6, 2022

I can see " All-Time Records" in your stat... I like to add this too... How did you do this? alos like the icons in your headlines. can you send me the code ... or create a PR for my fork ;-)

@seehase I see you already have the F-A icons working. 👍 Can't do a PR (won't let me since I already have the original repo forked), but I'll post the all-time records template snippet in your PR #54 shortly ;-)

…no data (and thusly preventing the display of null data and throwing 404/non-existent links).
@W0CHP W0CHP closed this by deleting the head repository Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants