Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form.field.ComboBox: does not hide the picker in case editable is false and opening it via a trigger click #5390

Closed
tobiu opened this issue Apr 12, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@tobiu
Copy link
Collaborator

tobiu commented Apr 12, 2024

@ExtAnimal

we have an override for onPickerTriggerClick() which does not honor the editable config.

inside form.field.Picker, we do have onInputClick(), which triggers togglePicker().

so, when editable is set to false, at first doFilter() gets called and then togglePicker(). it is a bit weird: after the show() call, a hide() call follows in real time. while i can not tell why the picker is not getting hidden right away, the hidden config does get changed to true. the result is that later hide() calls no longer work.

to fix this, i will just override togglePicker() to honor doFilter() and remove the onPickerTriggerClick() override. then editable true and false will both work again.

@tobiu tobiu added the bug Something isn't working label Apr 12, 2024
@tobiu tobiu self-assigned this Apr 12, 2024
@tobiu tobiu added this to To do in Client related tickets via automation Apr 12, 2024
tobiu added a commit that referenced this issue Apr 12, 2024
@tobiu tobiu closed this as completed Apr 12, 2024
Client related tickets automation moved this from To do to Done Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant