Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neo.isRecord() does not work in dist/production #5396

Closed
tobiu opened this issue Apr 16, 2024 · 0 comments
Closed

Neo.isRecord() does not work in dist/production #5396

tobiu opened this issue Apr 16, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@tobiu
Copy link
Collaborator

tobiu commented Apr 16, 2024

    static isRecord(value) {
        return value?.constructor?.name === 'Record' || false
    }

While we could change the logic to: item.isRecord (we do set a custom flag), the ctor name does get minified.

Since we are not minifying neo classNames I would argue that we should also not minify the name "Record", to give devs better chances of debugging inside dist/prod when needed.

@tobiu tobiu added the bug Something isn't working label Apr 16, 2024
@tobiu tobiu self-assigned this Apr 16, 2024
@tobiu tobiu closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant