Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Widescreen View - Index | Pager #2866

Closed
wants to merge 2 commits into from

Conversation

hanzyd
Copy link

@hanzyd hanzyd commented Mar 26, 2021

  • What does this PR do?

This example is a proof of concept for "Show index and body of emails in a horizontal split (side-by-side) #1250"

This is not really intended for merge, but could be used as a base for someone which will like to complete this, I think.
I think that I managed windows layout correctly, but they are few places in the index window management where probably better fixes are needed. These are places where index in minimised when pager have to be shown. Also space allocated for the pager is permanently visible. Side-by-side layout is controlled by option 'pager_columns', which more or less overwrite 'pager_index_lines'.

  • Screenshots (if relevant)

Screenshot

  • What are the relevant issue numbers?

Fixes #1250

This will allow index and pager to have differnt layouts,
not just vertical, but also side-by-side.
@flatcap flatcap changed the title Issue 1250 Create Widescreen View - Index | Pager Mar 26, 2021
@flatcap flatcap marked this pull request as draft March 26, 2021 11:34
@flatcap flatcap added type:discuss Your views/opinions are requested type:enhancement Feature Request labels Mar 26, 2021
@flatcap
Copy link
Member

flatcap commented Mar 26, 2021

Well done for creating this, @hanzyd.

I had a go myself last year: https://github.com/neomutt/neomutt-old#neomutt-2020-09-25
But then, and now, I didn't have the time to develop it.

The big problem I wanted to understand was about 'dividers'.
Who owned them? Who was responsible for drawing them?
Should the Window code be creating them automatically?

a base for someone which will like to complete this, I think.

and there's the problem. We have lots of ideas, but few people to implement them.

You've done a great job creating this PR -- the NeoMutt code can be hard to understand!
Have you got some time to work on it?

I'm always happy to mentor new NeoMutt coders ❤️

If you have any questions, feel free to ask them here,
or join us on IRC: #neomuttt on irc.freenode.net (web client)

Thanks!

@hanzyd
Copy link
Author

hanzyd commented Mar 26, 2021

Thanks! What I am not sure now is that widescreen mode is better than existing one. I mean, to be able to see more from the subject line I have to trim the date and time columns. Even after that subject line is badly trimmed.

I see that my attempt solving this is more or less the same what you have done.

I'll think a little about how the index visualisation could be optimised, and maybe I'll come back later.

Thanks for the help offered!

@flatcap
Copy link
Member

flatcap commented Apr 12, 2021

@flatcap flatcap closed this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:discuss Your views/opinions are requested type:enhancement Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show index and body of emails in a horizontal split (side-by-side)
2 participants