Fix use after free of a->mailbox due to missing strdup #3090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 87ae932 ("Directly add full mailbox to GPG search hints") changed crypt_add_string_to_hints(a->mailbox, &hints) to mutt_list_insert_tail(&hints, a->mailbox). However, there is a behavioural difference between the two functions: crypt_add_string_to_hints() adds a copy of the string to the list, while mutt_list_insert_tail() does not. This leads to a crash because the original a->mailbox is freed prematurely as part of the hints list. Fix this by adding a copy of the original to the list instead. Note that commit 87ae932 originally came from Mutt. Upstream is not affected by this however because their mutt_add_list() functions always copies the data.
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Oct 23, 2021
Credits @diabonas neomutt/neomutt#3090 git-svn-id: file:///srv/repos/svn-community/svn@1032960 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Oct 23, 2021
Credits @diabonas neomutt/neomutt#3090 git-svn-id: file:///srv/repos/svn-community/svn@1032960 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 87ae932 changed
crypt_add_string_to_hints(a->mailbox, &hints)tomutt_list_insert_tail(&hints, a->mailbox). However, there is a behavioural difference between the two functions:crypt_add_string_to_hints()adds a copy of the string to the list, whilemutt_list_insert_tail()does not. This leads to a crash because the originala->mailboxis freed prematurely as part of thehintslist. Fix this by adding a copy of the original to the list instead.Note that commit 87ae932 originally came from Mutt. Upstream is not affected by this however because their
mutt_add_list()functions always copies the data.Downstream tracking issue in Arch Linux: FS#72525