smtp: ignore oauth if it isn't configured and not requested #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gahr
approved these changes
Mar 30, 2023
This follows the same logic as all the other protocols, imap, pop etc. smtp seems to have been forgotten at the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the same logic as all the other protocols, imap, pop etc.
smtp seems to have been forgotten at the time.
This fixed the issue Dan had on the neomutt-users ML (I hope?)
It might also segfault, or eat my cat or whatever as I am not a C dev... just tried to replicate the imap code here.
I'm also not sure which header to include to get the Neomutt global object to get at the config option.