Mx alloc overhead reduction #4090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes neomutt#4087 - Fix overallocation of memory - Reduce number of re-allocations Reduce mx allocation overhead by gradually increasing grow step so far memory allocated for emails grew by capacity of 25 entries per each call. for big mailboxes this causes quite a lot of reallocations. change the logic to initially allocate 25 entries while further expansions double current capacity. cap number of new entries to 1000 though.
flatcap
force-pushed
the
mx-alloc-overhead-reduction
branch
from
6f71395
to
cddc83d
Compare
|
Squashed and added a comment. |
flatcap
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performance when increasing memory space required for mailbox.
Note that this PR is made on top of #4089. By no means this PR should be merged before #4087 is fixed as increasing
growto1000would absolutely blow memory requirements.Related to #4087.