Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not possible to recover from errors thrown by check #52

Closed
msvbg opened this issue Jan 22, 2016 · 3 comments
Closed

Not possible to recover from errors thrown by check #52

msvbg opened this issue Jan 22, 2016 · 3 comments
Labels
bug Triaged
Milestone
Error Safety

Comments

@msvbg
Copy link
Contributor

msvbg commented Jan 22, 2016

This is not possible if value is not an integer:

value.check::<JsInteger>().or(Ok(JsInteger::new(scope, 0)))

because the JsTypeError will crash the program.
@DemiMarie
Copy link

Neon probably needs to put everything in a C++ TryCatch.

@dherman dherman mentioned this issue Dec 2, 2016
Closed
3 tasks
dherman pushed a commit that referenced this issue Sep 18, 2017
Merge pull request #52 from neon-bindings/intelligent-rebuilds
df442e3 
Introduce the "artifacts file"
@divmain divmain added this to the Error Safety milestone Nov 22, 2017
@dherman
Copy link
Collaborator

dherman commented Nov 22, 2017

We'll need to flesh out the error safety design, which will probably need an RFC. See the milestone.

@dherman dherman mentioned this issue Nov 22, 2017
Open
@kjvalencik
Copy link
Member

There is now argument_opt and also try_catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Triaged
Projects
None yet
Milestone
Error Safety
Development

No branches or pull requests
5 participants
@dherman @kjvalencik @msvbg @divmain @DemiMarie