Windows linker issues #165
Conversation
Other platforms support dynamic lookup of symbols. On Windows, however, we always need to provide a .lib file with the node headers when linking the final dynamic library that will be used by Node applications. Signed-off-by: Nathan Sobo <nathan@github.com>
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
|
|
||
| # This name is arbitrary, but allows us to re-export the location of node.lib | ||
| # to dependent packages so they can link on Windows. | ||
| links = "neon-sys" |
There was a problem hiding this comment.
If this name is arbitrary, and we're hapy with the one chosen, maybe we could re-phrase this comment and add a link to the crates.io docs about this key.
# This name allows us to re-export the location of node.lib
# to dependent packages so they can link on Windows.
# http://doc.crates.io/build-script.html#the-links-manifest-keyThere was a problem hiding this comment.
I'll tweak the comment but separately I've filed #169 to rename neon-sys. Thanks for calling this out.
| }, | ||
| "devDependencies": { | ||
| "nan": "^2.3.2", | ||
| "node-gyp": "^3.3.1" |
There was a problem hiding this comment.
Do we expect node-gyp to be installed globally?
There was a problem hiding this comment.
It's installed with node (technically, npm) so yes. Depending on a specific node-gyp version is an anti-pattern in most cases.
I get bug reports from time to time where people complain node-gyp stopped working for them and then it turns out they've pinned it to a five years old release.
|
|
||
| [lib] | ||
| name = "tests" | ||
| crate-type = ["dylib"] | ||
|
|
||
| [dev-dependencies] | ||
| neon-build = "0.1.11" | ||
|
|
There was a problem hiding this comment.
So the neon-build crate isn't required in production? Will production builds still succeed?
There was a problem hiding this comment.
Good catch. Will fix.
There was a problem hiding this comment.
Also filed neon-bindings/neon-cli#46 and committed a fix for the template in the CLI.
(Pulled out from #122.)