Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Compilation Fixes #221

Merged
merged 5 commits into from
Aug 18, 2017
Merged

Windows Compilation Fixes #221

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b83c05
Fix linking neon-runtime on windows.
hone Aug 9, 2017
99be4c8
replace <(target_arch) string with the actual target_arch
hone Aug 11, 2017
a188d3d
make compatible with npm <= 5.0.0
hone Aug 18, 2017
a324cea
test latest + lts version of node, remove dupe platform matrix
hone Aug 18, 2017
331852f
fix gcc::Config deprecation warning
hone Aug 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,23 @@
os: Visual Studio 2015

platform:
- x64
- x86

environment:
NODEJS_VERSION: "6"
RUST_BACKTRACE: 1
matrix:
- NODE_ARCHITECTURE: x64
- PLATFORM: x64
NODEJS_VERSION: "6"
RUST_TOOLCHAIN: stable-x86_64-pc-windows-msvc

- NODE_ARCHITECTURE: x86
- PLATFORM: x86
NODEJS_VERSION: "6"
RUST_TOOLCHAIN: stable-i686-pc-windows-msvc
- PLATFORM: x64
NODEJS_VERSION: "8"
RUST_TOOLCHAIN: stable-x86_64-pc-windows-msvc
- PLATFORM: x86
NODEJS_VERSION: "8"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matrix looks good & looks like AppVeyor is green!
🍀 🍀 🍀 🍀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, yeah I wanted to test both LTS + latest and the old configuration was doing a 2x2 matrix where you'd test x64 toolchain on a x86 machine.

RUST_TOOLCHAIN: stable-i686-pc-windows-msvc

install:
- ps: Install-Product node $env:NODEJS_VERSION $env:NODE_ARCHITECTURE
- ps: Install-Product node $env:NODEJS_VERSION $env:PLATFORM
- npm config set msvs_version 2015
- node -e "console.log(process.argv[0], process.arch, process.versions)"

Expand Down