Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure #367

Merged
merged 1 commit into from
Mar 9, 2019
Merged

Fix build failure #367

merged 1 commit into from
Mar 9, 2019

Conversation

jjpe
Copy link
Contributor

@jjpe jjpe commented Oct 17, 2018

On MacOS and some Linux distro's the build failure caused by a devDependendy that should have been a dependency seems to be fixed by this commit, as outlined here.

@joelgallant
Copy link

This also works for me, I had issues with an in-docker build (joelgallant@7469fd1).

@PSeitz
Copy link

PSeitz commented Dec 11, 2018

@jjpe Can I use this directly from your fork?

@jjpe
Copy link
Contributor Author

jjpe commented Dec 11, 2018

@PSeitz you can but it's completely unsupported, so use at your own risk.

@PSeitz
Copy link

PSeitz commented Dec 11, 2018

@jjpe Sorry I meant to ask how. Not sure how to use it, because the only dependency in my package-lock.json is neon-cli.

@jjpe
Copy link
Contributor Author

jjpe commented Dec 11, 2018

Npm supports both git and path dependencies.
A git dependency to the fork seems easiest to do, as you wouldn't need to clone the fork.

For more info have a look at https://docs.npmjs.com/files/package.json (apologies for the ugly link)

@PSeitz
Copy link

PSeitz commented Dec 11, 2018

Ok now I got it, the dependency has to be specified in the Cargo.toml, because from there it starts the npm install

[patch.crates-io]
neon-runtime = { git = 'https://github.com/jjpe/neon' }

This solved the compile issue!
Would really appreciate if this gets merged.

@dherman
Copy link
Collaborator

dherman commented Mar 9, 2019

Thanks @jjpe for this PR, and for your patience 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants