Add functions to get JsString as UTF-16 #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjvalencik
reviewed
Nov 15, 2022
|
Sorry for the delay. Updated the PR with the requested changes, and I resolved the discussions accordingly. Feel free to re-open them if I missed anything. |
|
Is there anything to be done from my side, or is this just missing a final review? Would be great to have these extra APIs available soon-ish, but I might just point cargo to my PR branch in the meantime then 👍 |
|
Should be just the final review. I should have a chance this week. I haven't had a chance with Thanksgiving last week. |
kjvalencik
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending the API of
JsStringto retrieve the value as UTF-16 encodedVec<u16>. Also, added asize_utf16function for completeness.I added a few code samples to the API docs for
JsStringto show at least some basic uses, as the docs felt a bit empty for this rather core component.Fixes #943