✨ Config option to configure the https adaptive window size for requests #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neon-mmd
changed the title
neon-mmd
requested changes
Feb 20, 2024
Co-authored-by: neon_arch <mustafadhuleb53@gmail.com>
scottc943
reviewed
Feb 21, 2024
neon-mmd
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provided a new config option to allow user enable/disable the
httpswindow size setting for the requests fetching the search results from the upstream search engines.Why is this change important?
These change is essential as it allows the user to enable
httpsadaptive window sizes option for requests which improves the performance of requests on reliable/stable internet connections which in turn improves user experience ny reducing latency for responses.How to test this PR locally?
Check TCP SYN and ACK packets in wireshark for TCP Window Size scaling
Related issues
Closes #527