Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃┕ Temporary fix for minifying js files during build #565

Conversation

ddotthomas
Copy link
Contributor

@ddotthomas ddotthomas commented May 3, 2024

What does this PR do?

This PR replaces the original minify-js crate with its more actively developed and maintained fork.

Why is this change important?

This change is important as it provides a temporary fix for the bug caused while minifying the JS files during build until the main crate provides the fix for it.

How to test this PR locally?

Try running the build script both with and without the change.

env PKG_ENV=prod cargo build --release

Related issues

Closes #484

@neon-mmd neon-mmd changed the title 馃悰 Temporary fix for minifying js files 馃┕ Temporary fix for minifying js files during build May 3, 2024
Copy link
Owner

@neon-mmd neon-mmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 鉂わ笍 for working on this. We really appreciate it 馃憤 Keep it up!! Since everything looks good. We will merge this PR as soon as possible 馃檪 .

@neon-mmd neon-mmd merged commit 408858a into neon-mmd:rolling May 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

馃悰 Minification of javascript files fails while running the build command
2 participants