Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Minification of javascript files fails while running the build command #484

Closed
neon-mmd opened this issue Jan 7, 2024 · 4 comments · Fixed by #565
Closed

🐛 Minification of javascript files fails while running the build command #484

neon-mmd opened this issue Jan 7, 2024 · 4 comments · Fixed by #565

Comments

@neon-mmd
Copy link
Owner

neon-mmd commented Jan 7, 2024

Description

Recently, due to unknown reasons the minification of javascript files which happens when you set the PKG_ENV variable to prod and run the cargo build command seems to fail with an assertion error. So provide a fix for this issue by investigating the cause of the error and providing the updated code if necessary to fix this issue.

Additionally, The code for the minification of javascript files lies in the build.rs file under the codebase (websurfx directory).

Screenshots

No response

Do you want to work on this issue?

None

Additional information

No response

Copy link

github-actions bot commented Jan 7, 2024

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/neon-mmd/websurfx/blob/rolling/CONTRIBUTING.md

Copy link

github-actions bot commented Mar 8, 2024

Stale issue message

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
@neon-mmd neon-mmd reopened this Mar 15, 2024
@ddotthomas
Copy link
Contributor

This issue should be fixed as soon as wilsonzlin/minify-js#19 is pulled.

@neon-mmd
Copy link
Owner Author

This issue should be fixed as soon as wilsonzlin/minify-js#19 is pulled.

Since you are working on this issue. So we are assigning the issue to you. Now we would suggest you to continue working on this issue. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment