neon-storage-controller: add params for compute hook, readiness hook #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcdm
approved these changes
Feb 11, 2024
Lint checks require version bumps though. For other Helm apps we have pinned versions, we can adopt that approach for this one as well: https://github.com/neondatabase/aws/blob/main/.github/workflows/deploy-prod.yml#L4-L6 Also documentation lint is failing because there are two new config keys. |
Ah well, in that case I'll just bump the version. Added missing keys to the README as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intentionally not bumping the version because this can stay at 1.0.0 util it is stabilized enough to go into prod use.
/readyendpoint as readiness check.