Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(layer): metric splitting, span rename (#5902)
Per [feedback], split the Layer metrics, also finally account for lost and [re-submitted feedback] on `layer_gc` by renaming it to `layer_delete`, `Layer::garbage_collect_on_drop` renamed to `Layer::delete_on_drop`. References to "gc" dropped from metric names and elsewhere. Also fixes how the cancellations were tracked: there was one rare counter. Now there is a top level metric for cancelled inits, and the rare "download failed but failed to communicate" counter is kept. Fixes: #6027 [feedback]: #5809 (review) [re-submitted feedback]: #5108 (comment)
- Loading branch information
52718bb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2528 tests run: 2425 passed, 0 failed, 103 skipped (full report)
Flaky tests (2)
Postgres 16
test_statvfs_pressure_usage
: debugPostgres 14
test_gc_cutoff
: debugCode coverage (full report)
functions
:54.6% (9340 of 17108 functions)
lines
:82.2% (54183 of 65917 lines)
52718bb at 2023-12-07T10:39:55.350Z :recycle: