Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layer: metric name changes, track cancellations #6027

Closed
koivunej opened this issue Dec 4, 2023 · 0 comments · Fixed by #5902
Closed

layer: metric name changes, track cancellations #6027

koivunej opened this issue Dec 4, 2023 · 0 comments · Fixed by #5902

Comments

@koivunej
Copy link
Contributor

koivunej commented Dec 4, 2023

Originally posted by @koivunej in #6000 (comment)
@koivunej koivunej mentioned this issue Dec 5, 2023
Merged
koivunej added a commit that referenced this issue Dec 7, 2023
@koivunej
fix(layer): metric splitting, span rename (#5902)
52718bb 
Per [feedback], split the Layer metrics, also finally account for lost
and [re-submitted feedback] on `layer_gc` by renaming it to
`layer_delete`, `Layer::garbage_collect_on_drop` renamed to
`Layer::delete_on_drop`. References to "gc" dropped from metric names
and elsewhere.

Also fixes how the cancellations were tracked: there was one rare
counter. Now there is a top level metric for cancelled inits, and the
rare "download failed but failed to communicate" counter is kept.

Fixes: #6027

[feedback]: #5809 (review)
[re-submitted feedback]: #5108 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(layer): metric splitting, span rename neondatabase/neon
1 participant
@koivunej