Skip to content

Commit

Permalink
tests: add a log allow list to stabilize benchmarks (#7251)
Browse files Browse the repository at this point in the history
## Problem

#7227 destabilized various
tests in the performance suite, with log errors during shutdown. It's
because we switched shutdown order to stop the storage controller before
the pageservers.

## Summary of changes

- Tolerate "connection failed" errors from pageservers trying to
validation their deletion queue.
  • Loading branch information
jcsp committed Mar 26, 2024
1 parent b3bb1d1 commit 6814bb4
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions test_runner/fixtures/pageserver/allowed_errors.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ def scan_pageserver_log_for_errors(
# This is especially pronounced in tests that set small checkpoint
# distances.
".*Flushed oversized open layer with size.*",
# During teardown, we stop the storage controller before the pageservers, so pageservers
# can experience connection errors doing background deletion queue work.
".*WARN deletion backend: calling control plane generation validation API failed.*Connection refused.*",
)


Expand Down

1 comment on commit 6814bb4

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2810 tests run: 2655 passed, 0 failed, 155 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_vm_bit_clear_on_heap_lock: debug

Code coverage* (full report)

  • functions: 28.2% (6299 of 22349 functions)
  • lines: 47.0% (44248 of 94196 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6814bb4 at 2024-03-26T18:41:41.451Z :recycle:

Please sign in to comment.