Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add a log allow list to stabilize benchmarks #7251

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Mar 26, 2024

Problem

#7227 destabilized various tests in the performance suite, with log errors during shutdown. It's because we switched shutdown order to stop the storage controller before the pageservers.

Summary of changes

  • Tolerate "connection failed" errors from pageservers trying to validation their deletion queue.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@jcsp jcsp added a/test Area: related to testing a/tech_debt Area: related to tech debt run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label labels Mar 26, 2024
@jcsp jcsp requested a review from bayandin March 26, 2024 15:28
@jcsp jcsp enabled auto-merge (squash) March 26, 2024 15:42
@jcsp jcsp disabled auto-merge March 26, 2024 15:42
Copy link

2798 tests run: 2648 passed, 0 failed, 150 skipped (full report)


Code coverage* (full report)

  • functions: 28.2% (6295 of 22343 functions)
  • lines: 47.0% (44212 of 94145 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
154742f at 2024-03-26T16:43:21.887Z :recycle:

@jcsp jcsp merged commit 6814bb4 into main Mar 26, 2024
60 checks passed
@jcsp jcsp deleted the jcsp/benchmarks-log-flake branch March 26, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/tech_debt Area: related to tech debt a/test Area: related to testing run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants