Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: ResidentLayer::load_keys should not create INFO level span (#7174)
Since #6115 with more often used get_value_reconstruct_data and friends, we should not have needless INFO level span creation near hot paths. In our prod configuration, INFO spans are always created, but in practice, very rarely anything at INFO level is logged underneath. `ResidentLayer::load_keys` is only used during compaction so it is not that hot, but this aligns the access paths and their span usage. PR changes the span level to debug to align with others, and adds the layer name to the error which was missing. Split off from #7030.
- Loading branch information
fb66a3d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2786 tests run: 2642 passed, 2 failed, 142 skipped (full report)
Failures on Postgres 14
test_pgbench_intensive_init_workload[neon_on-github-actions-selfhosted-1000]
: releasetest_bulk_insert[neon-github-actions-selfhosted]
: releaseCode coverage* (full report)
functions
:28.3% (7131 of 25198 functions)
lines
:46.9% (43708 of 93290 lines)
* collected from Rust tests only
fb66a3d at 2024-03-20T15:14:06.942Z :recycle: