Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ResidentLayer::load_keys should not create INFO level span #7174

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

koivunej
Copy link
Contributor

@koivunej koivunej commented Mar 19, 2024

Since #6115 with more often used get_value_reconstruct_data and friends, we should not have needless INFO level span creation near hot paths. In our prod configuration, INFO spans are always created, but in practice, very rarely anything at INFO level is logged underneath. ResidentLayer::load_keys is only used during compaction so it is not that hot, but this aligns the access paths and their span usage.

PR changes the span level to debug to align with others, and adds the layer name to the error which was missing.

Split off from #7030.

@koivunej koivunej requested a review from a team as a code owner March 19, 2024 13:03
@koivunej koivunej requested a review from arpad-m March 19, 2024 13:03
Copy link

2706 tests run: 2576 passed, 0 failed, 130 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_vm_bit_clear_on_heap_lock: release

Code coverage* (full report)

  • functions: 28.3% (7132 of 25174 functions)
  • lines: 46.9% (43730 of 93326 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
1387f28 at 2024-03-19T13:49:33.610Z :recycle:

@koivunej koivunej merged commit fb66a3d into main Mar 20, 2024
53 checks passed
@koivunej koivunej deleted the joonas/drive-by-span-adjust branch March 20, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants