Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgres does not enter replica mode when it can / cannot start two replicas #7204

Closed
skyzh opened this issue Mar 21, 2024 · 0 comments · Fixed by #7209
Closed

Postgres does not enter replica mode when it can / cannot start two replicas #7204

skyzh opened this issue Mar 21, 2024 · 0 comments · Fixed by #7209
Labels
c/storage/compute Component: storage: compute t/bug Issue Type: Bug

Comments

@skyzh
Copy link
Member

skyzh commented Mar 21, 2024

Steps to reproduce

Run hot_standby test with two replicas

Expected result

Success

Actual result

The first replica starts only after a new log is appended to WAL. The second replica does not start as the primary does not attempt to write any log to the WAL.

Environment

Logs, links
@skyzh skyzh added t/bug Issue Type: Bug c/storage/compute Component: storage: compute labels Mar 21, 2024
@skyzh skyzh changed the title Postgres does not enter replica mode when it can Postgres does not enter replica mode when it can / cannot start two replicas Mar 22, 2024
This was referenced Mar 22, 2024
Merged
Merged
Merged
Merged
skyzh added a commit that referenced this issue Mar 22, 2024
@skyzh
fixup(#7204): revert IsPrimaryAlive checks
5a8380c
This was referenced Mar 22, 2024
Merged
Closed
skyzh added a commit that referenced this issue Mar 22, 2024
@skyzh
fixup(#7204): revert IsPrimaryAlive checks
8b27aaa
skyzh added a commit that referenced this issue Mar 23, 2024
@skyzh
fixup(#7204 / postgres): revert IsPrimaryAlive checks (#7209)
643683f 
Fix #7204.

neondatabase/postgres#400
neondatabase/postgres#401
neondatabase/postgres#402

These commits never go into prod. Detailed investigation will be posted
in another issue. Reverting the commits so that things can keep running
in prod. This pull request adds the test to start two replicas. It fails
on the current main #7210 but
passes in this pull request.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
This was referenced Mar 25, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c/storage/compute Component: storage: compute t/bug Issue Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixup(#7204 / postgres): revert IsPrimaryAlive checks neondatabase/neon
1 participant
@skyzh