Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert IsPrimaryAlive checks #402

Merged
merged 2 commits into from
Mar 22, 2024
Merged

Revert IsPrimaryAlive checks #402

merged 2 commits into from
Mar 22, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Mar 22, 2024

@skyzh
Revert "Add comment explaining why it is safe to use FirstNormalTrans…
d9d08fa 
…actionXid for oldestActiveXid while replica startup (#387)"

This reverts commit 67240b5.
@skyzh
Revert "Set wasShutdown=true during hot-standby replica startup only …
b709ad9 
…when primary is not alive (#363)"

This reverts commit 61c280c.
@skyzh skyzh requested a review from knizhnik March 22, 2024 13:57
@skyzh skyzh mentioned this pull request Mar 22, 2024
Merged
5 tasks
@skyzh skyzh merged commit 3946b2e into REL_16_STABLE_neon Mar 22, 2024
@skyzh skyzh deleted the skyzh/revert-wasshutdown-pg16 branch March 22, 2024 17:01
skyzh added a commit to neondatabase/neon that referenced this pull request Mar 23, 2024
@skyzh
fixup(#7204 / postgres): revert IsPrimaryAlive checks (#7209)
643683f 
Fix #7204.

neondatabase/postgres#400
neondatabase/postgres#401
neondatabase/postgres#402

These commits never go into prod. Detailed investigation will be posted
in another issue. Reverting the commits so that things can keep running
in prod. This pull request adds the test to start two replicas. It fails
on the current main #7210 but
passes in this pull request.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
tristan957 pushed a commit that referenced this pull request May 10, 2024
@skyzh @tristan957
Revert IsPrimaryAlive checks (#402)
e49bbaa 
* Revert "Add comment explaining why it is safe to use FirstNormalTransactionXid for oldestActiveXid while replica startup (#387)"

This reverts commit 67240b5.

* Revert "Set wasShutdown=true during hot-standby replica startup only when primary is not alive (#363)"

This reverts commit 61c280c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knizhnik knizhnik knizhnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skyzh @knizhnik