Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import all existing RFCs documents from the separate 'rfcs' repository. #1353

Merged
merged 1 commit into from
Mar 12, 2022

Conversation

hlinnaka
Copy link
Contributor

This is the same that @stepashka did in PR #1145. I was skeptical then, because some of these RFCs don't really reflect the reality. But after talking with Anna, I've come around that despite that, it's better to have them all in the same git repository. It gives them more visibility, and it makes it more natural to open a new PR for an RFCs

I added a README explaining what the RFCs are, with a warning that some of them are outdated. I copied the instructions that we had on Notion previously there as well, so that it's all in one place.

@hlinnaka hlinnaka requested a review from stepashka March 11, 2022 16:54
@hlinnaka
Copy link
Contributor Author

@funbringer you +1'd my earlier scepticism on this. How do you feel about this now, with the caveat in the README?

@funbringer
Copy link
Contributor

@funbringer you +1'd my earlier scepticism on this. How do you feel about this now, with the caveat in the README?

I agree, the guideline for RFCs is definitely going to help us understand their place in the project. After all, maybe the change is for the better. We'll see :)

@hlinnaka hlinnaka merged commit d93fc37 into main Mar 12, 2022
@hlinnaka hlinnaka deleted the import-rfcs2 branch March 12, 2022 09:30
@stepashka stepashka added the t/tech_design_rfc Issue type: tech design RFC label May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t/tech_design_rfc Issue type: tech design RFC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants