Login to ECR and Docker Hub at once #4067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test results for 3ebd688:debug build: 219 tests run: 209 passed, 0 failed, 10 (full report)release build: 219 tests run: 209 passed, 0 failed, 10 (full report) |
bayandin
changed the title
SergeyMelnikov
approved these changes
Apr 25, 2023
zoete
approved these changes
Apr 25, 2023
bayandin
force-pushed
the
bayandin/better-kaniko
branch
from
8c720b2
to
07266c5
Compare
5 tasks
bayandin
added a commit
that referenced
this pull request
Apr 25, 2023
Follow-up fix after #4067 ``` + crane tag neondatabase/vm-compute-node-v14:3064 latest Error: fetching "neondatabase/vm-compute-node-v14:3064": GET https://index.docker.io/v2/neondatabase/vm-compute-node-v14/manifests/3064: MANIFEST_UNKNOWN: manifest unknown; unknown tag=3064 ``` I reverted back the previous approach for promoting images (login to one registry, save images to local fs, logout and login to another registry, and push images from local fs). It turns out what works for one Google project (kaniko), doesn't work for another (crane) [sigh]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
push-docker-hubunneededpush-docker-hubreplaced withpromote-imagesinneeds:clause, Pushing images to production ECR moved topromote-imagesjob