Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tenant create / update-config: reject unknown fields #4267

Merged
merged 9 commits into from
May 19, 2023
Merged

tenant create / update-config: reject unknown fields #4267

merged 9 commits into from
May 19, 2023

Commits on May 17, 2023

  1. neon_local tenant config: ensure that all supplied config args have b… 

    …een used

This does it like `tenant create`.

We should dedupe these at a future point in time.
    @problame
    problame committed May 17, 2023
    Configuration menu
    Copy the full SHA
    fdd504f View commit details
    Browse the repository at this point in the history

  2. tenant create / config API: enforce that all supplied keys are valid 

    This could have been a simple `#[serde(deny_unknown_fields)]` but sadly,
that is documented, but compile-time-silently incompatible with
`#[serde(flatten)]`.
    @problame
    problame committed May 17, 2023
    Configuration menu
    Copy the full SHA
    18f6ccd View commit details
    Browse the repository at this point in the history

  3. add regression tests

    @problame
    problame committed May 17, 2023
    Configuration menu
    Copy the full SHA
    d287e6a View commit details
    Browse the repository at this point in the history

  4. mypy

    @problame
    problame committed May 17, 2023
    Configuration menu
    Copy the full SHA
    d551de6 View commit details
    Browse the repository at this point in the history

  5. clippy

    @problame
    problame committed May 17, 2023
    Configuration menu
    Copy the full SHA
    4967355 View commit details
    Browse the repository at this point in the history

  6. reject unknown field in tenant config 

    Signed-off-by: Alex Chi <iskyzh@gmail.com>
    @skyzh
    skyzh committed May 17, 2023
    Configuration menu
    Copy the full SHA
    88ad410 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. use serde deny unknown fields 

    Signed-off-by: Alex Chi <iskyzh@gmail.com>
    @skyzh
    skyzh committed May 18, 2023
    Configuration menu
    Copy the full SHA
    8934ffc View commit details
    Browse the repository at this point in the history

  2. rm unused imports 

    Signed-off-by: Alex Chi <iskyzh@gmail.com>
    @skyzh
    skyzh committed May 18, 2023
    Configuration menu
    Copy the full SHA
    a75a87b View commit details
    Browse the repository at this point in the history

  3. fix python style 

    Signed-off-by: Alex Chi <iskyzh@gmail.com>
    @skyzh
    skyzh committed May 18, 2023
    Configuration menu
    Copy the full SHA
    fc9653c View commit details
    Browse the repository at this point in the history