Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/ingest_perf_test_result.py: increase connection timeout #4329

Merged
merged 1 commit into from
May 24, 2023

Conversation

bayandin
Copy link
Member

Problem

Sometimes default connection timeout is not enough to connect to the DB with perf test results, an example.

Similar changes were made for similar scripts:

Summary of changes

  • Connection timeout increased to 30s for scripts/ingest_perf_test_result.py

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@bayandin bayandin requested a review from koivunej May 24, 2023 11:45
@github-actions
Copy link

976 tests run: 936 passed, 0 failed, 40 skipped (full report)


The comment gets automatically updated with the latest test results
8f6f107 at 2023-05-24T12:04:07.583Z :recycle:

@skyzh skyzh merged commit 35bb107 into main May 24, 2023
26 checks passed
@skyzh skyzh deleted the bayandin/increase-connection-timeout branch May 24, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants