New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tokio-epoll-uring: use it for on-demand downloads #6992
Merged
problame
merged 104 commits into
main
from
problame/integrate-tokio-epoll-uring/write-path/ondemand-downloads
Mar 15, 2024
Merged
tokio-epoll-uring: use it for on-demand downloads #6992
problame
merged 104 commits into
main
from
problame/integrate-tokio-epoll-uring/write-path/ondemand-downloads
Mar 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can probably get rid of the entire trait, but, that's for another time.
…uilder-refactor' into problame/integrate-tokio-epoll-uring/write-path/simplify-write-at-api
This reverts commit b5a00b0.
…ath/refactor-blob-writer
…ath/refactor-blob-writer
…r-blob-writer' into problame/integrate-tokio-epoll-uring/write-path/refactor-virtual-file
…ath/refactor-blob-writer
problame
changed the title
WIP: tokio epoll uring: use it for on-demand downloads
tokio epoll uring: use it for on-demand downloads
Mar 13, 2024
problame
changed the title
tokio epoll uring: use it for on-demand downloads
tokio-epoll-uring: use it for on-demand downloads
Mar 13, 2024
problame
commented
Mar 13, 2024
problame
commented
Mar 13, 2024
problame
commented
Mar 13, 2024
koivunej
reviewed
Mar 13, 2024
koivunej
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OwnedAsyncWriter looks good, nice tests around the buffering.
problame
commented
Mar 13, 2024
problame
added a commit
that referenced
this pull request
Mar 13, 2024
The OwnedAsyncWrite stuff is based on the code in tokio-epoll-uring on-demand download PR (#6992), which hasn't merged yet.
…kio-epoll-uring/write-path/ondemand-downloads
Only got to do the performance testing now, but, I think this is a fairly safe change, so, merging it now, even if there's less soak time before the next release. |
…ring/write-path/ondemand-downloads' into problame/integrate-tokio-epoll-uring/write-path/ondemand-downloads
…kio-epoll-uring/write-path/ondemand-downloads
…l-uring/write-path/ondemand-downloads
problame
deleted the
problame/integrate-tokio-epoll-uring/write-path/ondemand-downloads
branch
March 15, 2024 18:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
run-benchmarks
Indicates to the CI that benchmarks should be run for PR marked with this label
run-extra-build-macos
When placed on a PR, tells the CI to run a build on macOS. No unit tests are run, though.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On-demand downloads are still using
tokio::fs
, which we know is inefficient.Changes
pagebench ondemand-download-churn
to quantify on-demand download throughputhistory_buffer
implDeserialize
tokio::io::copy_buf
for owned buffers =>owned_buffers_io
module and children.io_engine::get()
, using VirtualFile + above copy loopretry_download
, e.g.,sync_all()
call.Drive-by:
scripts/ps_ec2_setup_instance_store
NotFound
, andabort()
the process usingon_fatal_io_error
. This PR adds treatsNotFound
as a success.Testing
Functional
Performance
ondemand-download-churn
benchmark to manually test against real S3.Future Work
Turn the manual performance testing described in the above results document into a performance regression test: #7146